netdev - Re: [PATCH net v4 02/11] net: hold instance lock during NETDEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250331142736.263cbd6f@kernel.org>
Date: Mon, 31 Mar 2025 14:27:36 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Stanislav Fomichev <stfomichev@...il.com>
Cc: Stanislav Fomichev <sdf@...ichev.me>, netdev@...r.kernel.org,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com, Cosmin Ratiu
 <cratiu@...dia.com>
Subject: Re: [PATCH net v4 02/11] net: hold instance lock during
 NETDEV_REGISTER/UP

On Mon, 31 Mar 2025 14:13:09 -0700 Stanislav Fomichev wrote:
> > > @@ -3042,14 +3040,16 @@ static int do_setlink(const struct sk_buff *skb, struct net_device *dev,
> > >  
> > >  		new_ifindex = nla_get_s32_default(tb[IFLA_NEW_IFINDEX], 0);
> > >  
> > > -		err = netif_change_net_namespace(dev, tgt_net, pat,
> > > -						 new_ifindex, extack);
> > > +		err = __dev_change_net_namespace(dev, tgt_net, pat, new_ifindex,  
> > 
> > nit: over 80 chars now  
> 
> It's exactly 80, is it considered over? This has been done by clang
> formatter which has 'ColumnLimit: 80'.. Will undo regardless, but lmk
> if the rule is >80 or >=80 (the formatter thinks it's the former)

My bad, unplugging the external screen seems to slightly shrink windows
in GNOME. My terminal was set to 79 chars :S