netdev - Re: [PATCH] ppp: Pass PPP Kconfig defines through to the CPP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <b5e6d8a2-df18-4e64-938e-39e73d1214f9@lunn.ch>
Date: Tue, 1 Apr 2025 16:26:23 +0200
From: Andrew Lunn <andrew@...n.ch>
To: steve@...wbury.org.uk
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ppp: Pass PPP Kconfig defines through to the CPP

On Mon, Mar 31, 2025 at 08:49:16PM +0100, steve@...wbury.org.uk wrote:
> From: Steven Newbury <steve@...wbury.org.uk>
> 
> It seems for a very long time the conditional code in ppp_generic.c for PPP_MULTILINK
> and PPP_FILTER hasn't been compiled!  I do wonder whether anybody actually still uses
> these options!
> ---
>  drivers/net/ppp/Makefile | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/net/ppp/Makefile b/drivers/net/ppp/Makefile
> index 16c457d6b324..9d12915e4ac5 100644
> --- a/drivers/net/ppp/Makefile
> +++ b/drivers/net/ppp/Makefile
> @@ -12,3 +12,10 @@ obj-$(CONFIG_PPP_SYNC_TTY) += ppp_synctty.o
>  obj-$(CONFIG_PPPOE) += pppox.o pppoe.o
>  obj-$(CONFIG_PPPOL2TP) += pppox.o
>  obj-$(CONFIG_PPTP) += pppox.o pptp.o
> +
> +ifdef CONFIG_PPP_MULTILINK
> +ccflags-y += -DCONFIG_PPP_MULTILINK
> +endif
> +ifdef CONFIG_PPP_FILTER
> +ccflags-y += -DCONFIG_PPP_FILTER
> +endif

That looks very odd. I don't see many other instances for Makefiles
doing this. Please add a bigger explanation of why this is needed, and
why the usual Kconfig mechanism don't work.

    Andrew

---
pw-bot: cr