netdev - Re: [PATCH v12 01/23] cxl: add type2 device basic support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <09720c8c-a1bc-42d9-8725-14b208534755@amd.com>
Date: Tue, 1 Apr 2025 18:36:29 +0100
From: Alejandro Lucero Palau <alucerop@....com>
To: alejandro.lucero-palau@....com, linux-cxl@...r.kernel.org,
 netdev@...r.kernel.org, dan.j.williams@...el.com, edward.cree@....com,
 davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
 edumazet@...gle.com, dave.jiang@...el.com
Subject: Re: [PATCH v12 01/23] cxl: add type2 device basic support


On 3/31/25 15:45, alejandro.lucero-palau@....com wrote:
> From: Alejandro Lucero <alucerop@....com>
>
> Differentiate CXL memory expanders (type 3) from CXL device accelerators
> (type 2) with a new function for initializing cxl_dev_state and a macro
> for helping accel drivers to embed cxl_dev_state inside a private
> struct.
>
> Move structs to include/cxl as the size of the accel driver private
> struct embedding cxl_dev_state needs to know the size of this struct.
>
> Use same new initialization with the type3 pci driver.
>
> Signed-off-by: Alejandro Lucero <alucerop@....com>
> ---
>   drivers/cxl/core/mbox.c      |  11 +-
>   drivers/cxl/core/memdev.c    |  32 ++++++
>   drivers/cxl/core/pci.c       |   1 +
>   drivers/cxl/core/regs.c      |   1 +
>   drivers/cxl/cxl.h            |  97 +---------------
>   drivers/cxl/cxlmem.h         |  88 +--------------
>   drivers/cxl/cxlpci.h         |  25 +----
>   drivers/cxl/pci.c            |  17 +--
>   include/cxl/cxl.h            | 209 +++++++++++++++++++++++++++++++++++
>   include/cxl/pci.h            |  23 ++++
>   tools/testing/cxl/test/mem.c |   2 +-
>   11 files changed, 290 insertions(+), 216 deletions(-)
>   create mode 100644 include/cxl/cxl.h
>   create mode 100644 include/cxl/pci.h
>
<snip>


> diff --git a/tools/testing/cxl/test/mem.c b/tools/testing/cxl/test/mem.c
> index 0ceba8aa6eec..6e9b3141035b 100644
> --- a/tools/testing/cxl/test/mem.c
> +++ b/tools/testing/cxl/test/mem.c
> @@ -1611,6 +1611,7 @@ static int cxl_mock_mem_probe(struct platform_device *pdev)
>   	if (rc)
>   		return rc;
>   
> +	mds = cxl_memdev_state_create(dev, pdev->id + 1, NULL);
>   	mds = cxl_memdev_state_create(dev);


Patch did not apply properly :-(

The call with the old interface needs to be removed.