netdev - Re: [PATCH net] ipv6: fix omitted netlink attributes when using RTEXT_FILTER_SKIP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250401094246.GB214849@horms.kernel.org>
Date: Tue, 1 Apr 2025 10:42:46 +0100
From: Simon Horman <horms@...nel.org>
To: Fernando Fernandez Mancera <ffmancera@...eup.net>
Cc: netdev@...r.kernel.org, sowmini.varadhan@...cle.com
Subject: Re: [PATCH net] ipv6: fix omitted netlink attributes when using
 RTEXT_FILTER_SKIP_STATS

On Mon, Mar 31, 2025 at 06:36:51PM +0200, Fernando Fernandez Mancera wrote:
> Using RTEXT_FILTER_SKIP_STATS should not skip non-statistics IPv6
> netlink attributes. Move the filling of IFLA_INET6_STATS and
> IFLA_INET6_ICMP6STATS to a helper function to avoid hitting the same
> situation in the future.
> 
> Fixes: d5566fd72ec1 ("rtnetlink: RTEXT_FILTER_SKIP_STATS support to avoid dumping inet/inet6 stats")
> Signed-off-by: Fernando Fernandez Mancera <ffmancera@...eup.net>

Hi Fernando,

I think that it would be good to describe what problem the user experiences
without this change - yes, I can see which attributes aren't dumped,
but what problem does that cause? Doubly so as this is marked as a bug fix.

Thanks!