netdev - Re: [PATCH net] selftests: tc-testing: fix nat regex matching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250401095349.GC214849@horms.kernel.org>
Date: Tue, 1 Apr 2025 10:53:49 +0100
From: Simon Horman <horms@...nel.org>
To: Pedro Tammela <pctammela@...atatu.com>
Cc: netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
	jiri@...nulli.us, shuah@...nel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net] selftests: tc-testing: fix nat regex matching

On Mon, Mar 31, 2025 at 04:56:18PM -0300, Pedro Tammela wrote:
> In iproute 6.14, the nat ip mask logic was fixed to remove a undefined
> behaviour. So now instead of reporting '0.0.0.0/32' on x86 and potentially
> '0.0.0.0/0' in other platforms, it reports '0.0.0.0/0' in all platforms.
> 

Hi Pedro,

As a fix for 'net' usually a Fixes tag would go here.
But perhaps that isn't appropriate in this case for some reason?

> Signed-off-by: Pedro Tammela <pctammela@...atatu.com>

I am assuming that you are referring to this fix:

- [PATCH iproute2-next] tc: nat: Fix mask calculation
  https://lore.kernel.org/netdev/20250306112520.188728-1-torben.nielsen@prevas.dk/

If so, it might be nice to include a reference to it in the commit message.

And also, if so, this change looks good to me:

Reviewed-by: Simon Horman <horms@...nel.org>