netdev - Re: [PATCH net v2] ipv6: fix omitted netlink attributes when using RTEXT_FILTER_SKIP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250402142537.GT214849@horms.kernel.org>
Date: Wed, 2 Apr 2025 15:25:37 +0100
From: Simon Horman <horms@...nel.org>
To: Fernando Fernandez Mancera <ffmancera@...eup.net>
Cc: netdev@...r.kernel.org, dsahern@...nel.org, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com
Subject: Re: [PATCH net v2] ipv6: fix omitted netlink attributes when using
 RTEXT_FILTER_SKIP_STATS

On Wed, Apr 02, 2025 at 02:17:51PM +0200, Fernando Fernandez Mancera wrote:
> Using RTEXT_FILTER_SKIP_STATS is incorrectly skipping non-stats IPv6
> netlink attributes on link dump. This causes issues on userspace tools,
> e.g iproute2 is not rendering address generation mode as it should due
> to missing netlink attribute.
> 
> Move the filling of IFLA_INET6_STATS and IFLA_INET6_ICMP6STATS to a
> helper function guarded by a flag check to avoid hitting the same
> situation in the future.
> 
> Fixes: d5566fd72ec1 ("rtnetlink: RTEXT_FILTER_SKIP_STATS support to avoid dumping inet/inet6 stats")
> Signed-off-by: Fernando Fernandez Mancera <ffmancera@...eup.net>

Reviewed-by: Simon Horman <horms@...nel.org>