netdev - Re: [PATCH net 0/2] net: make memory provider install / close paths more common

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMArcTWYSOZGKi1C8YTzSB7XnYb6xKLdKGF8nujX8Y0E3vRg3Q@mail.gmail.com>
Date: Thu, 3 Apr 2025 00:35:47 +0900
From: Taehee Yoo <ap420073@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, 
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org, 
	asml.silence@...il.com, almasrymina@...gle.com, dw@...idwei.uk, 
	sdf@...ichev.me
Subject: Re: [PATCH net 0/2] net: make memory provider install / close paths
 more common

On Tue, Apr 1, 2025 at 4:42 AM Jakub Kicinski <kuba@...nel.org> wrote:
>

Hi Jakub,
Thanks a lot for this fix!

> We seem to be fixing bugs in config path for devmem which also exist
> in the io_uring ZC path. Let's try to make the two paths more common,
> otherwise this is bound to keep happening.
>
> Found by code inspection and compile tested only.

I tested this patchset with my RFC[1].
This works well, and I can't see any splat by kmemleak, lockdep, etc.

[1]https://lore.kernel.org/netdev/20250331114729.594603-1-ap420073@gmail.com/

Thanks a lot!
Taehee Yoo

>
> Jakub Kicinski (2):
>   net: move mp dev config validation to __net_mp_open_rxq()
>   net: avoid false positive warnings in __net_mp_close_rxq()
>
>  include/net/page_pool/memory_provider.h |  6 +++
>  net/core/devmem.c                       | 64 ++++++------------------
>  net/core/netdev-genl.c                  |  6 ---
>  net/core/netdev_rx_queue.c              | 66 ++++++++++++++++++-------
>  4 files changed, 69 insertions(+), 73 deletions(-)
>
> --
> 2.49.0
>