netdev - Re: [PATCH net] sctp: add mutual exclusion in proc_sctp_do_udp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <174363723326.1716091.14559512719175692970.git-patchwork-notify@kernel.org>
Date: Wed, 02 Apr 2025 23:40:33 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Eric Dumazet <edumazet@...gle.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
 netdev@...r.kernel.org, eric.dumazet@...il.com,
 syzbot+fae49d997eb56fa7c74d@...kaller.appspotmail.com,
 marcelo.leitner@...il.com, lucien.xin@...il.com
Subject: Re: [PATCH net] sctp: add mutual exclusion in proc_sctp_do_udp_port()

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Mon, 31 Mar 2025 09:15:32 +0000 you wrote:
> We must serialize calls to sctp_udp_sock_stop() and sctp_udp_sock_start()
> or risk a crash as syzbot reported:
> 
> Oops: general protection fault, probably for non-canonical address 0xdffffc000000000d: 0000 [#1] SMP KASAN PTI
> KASAN: null-ptr-deref in range [0x0000000000000068-0x000000000000006f]
> CPU: 1 UID: 0 PID: 6551 Comm: syz.1.44 Not tainted 6.14.0-syzkaller-g7f2ff7b62617 #0 PREEMPT(full)
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2025
>  RIP: 0010:kernel_sock_shutdown+0x47/0x70 net/socket.c:3653
> Call Trace:
>  <TASK>
>   udp_tunnel_sock_release+0x68/0x80 net/ipv4/udp_tunnel_core.c:181
>   sctp_udp_sock_stop+0x71/0x160 net/sctp/protocol.c:930
>   proc_sctp_do_udp_port+0x264/0x450 net/sctp/sysctl.c:553
>   proc_sys_call_handler+0x3d0/0x5b0 fs/proc/proc_sysctl.c:601
>   iter_file_splice_write+0x91c/0x1150 fs/splice.c:738
>   do_splice_from fs/splice.c:935 [inline]
>   direct_splice_actor+0x18f/0x6c0 fs/splice.c:1158
>   splice_direct_to_actor+0x342/0xa30 fs/splice.c:1102
>   do_splice_direct_actor fs/splice.c:1201 [inline]
>   do_splice_direct+0x174/0x240 fs/splice.c:1227
>   do_sendfile+0xafd/0xe50 fs/read_write.c:1368
>   __do_sys_sendfile64 fs/read_write.c:1429 [inline]
>   __se_sys_sendfile64 fs/read_write.c:1415 [inline]
>   __x64_sys_sendfile64+0x1d8/0x220 fs/read_write.c:1415
>   do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
> 
> [...]

Here is the summary with links:
  - [net] sctp: add mutual exclusion in proc_sctp_do_udp_port()
    https://git.kernel.org/netdev/net/c/10206302af85

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html