netdev - Re: [PATCH net v5 02/11] net: hold instance lock during NETDEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250402170220.4619a783@kernel.org>
Date: Wed, 2 Apr 2025 17:02:20 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Stanislav Fomichev <sdf@...ichev.me>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, Cosmin Ratiu <cratiu@...dia.com>
Subject: Re: [PATCH net v5 02/11] net: hold instance lock during
 NETDEV_REGISTER/UP

On Tue,  1 Apr 2025 09:34:43 -0700 Stanislav Fomichev wrote:
> +	netdev_lock_ops(dev);
>  	/* If device is running close it first. */
>  	netif_close(dev);
> -
>  	/* And unlink it from device chain */
>  	unlist_netdevice(dev);
> +	netdev_unlock_ops(dev);

Is there a reason we don't hold the instance lock over
unlist_netdevice() in unregister_netdevice_many_notify()
but we do here? We need a separate fix for that..
but this series is big enough already. Unless there's
a reason I think we should be consistent and not lock
over the listing?