netdev - Re: [PATCH net v2 0/3] net_sched: sch_sfq: reject a derived limit of 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z+8BHkw5Q0KtASdm@pop-os.localdomain>
Date: Thu, 3 Apr 2025 14:43:58 -0700
From: Cong Wang <xiyou.wangcong@...il.com>
To: Octavian Purdila <tavip@...gle.com>
Cc: jhs@...atatu.com, jiri@...nulli.us, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	horms@...nel.org, shuah@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net v2 0/3] net_sched: sch_sfq: reject a derived limit of
 1

On Wed, Apr 02, 2025 at 09:27:47AM -0700, Octavian Purdila wrote:
> Because sfq parameters can influence each other there can be
> situations where although the user sets a limit of 2 it can be lowered
> to 1:
> 
> $ tc qdisc add dev dummy0 handle 1: root sfq limit 2 flows 1 depth 1
> $ tc qdisc show dev dummy0
> qdisc sfq 1: dev dummy0 root refcnt 2 limit 1p quantum 1514b depth 1 divisor 1024
> 
> $ tc qdisc add dev dummy0 handle 1: root sfq limit 2 flows 10 depth 1 divisor 1
> $ tc qdisc show dev dummy0
> qdisc sfq 2: root refcnt 2 limit 1p quantum 1514b depth 1 divisor 1
> 
> As a limit of 1 is invalid, this patch series moves the limit
> validation to after all configuration changes have been done. To do
> so, the configuration is done in a temporary work area then applied to
> the internal state.
> 
> The patch series also adds new test cases.

Acked-by: Cong Wang <xiyou.wangcong@...il.com>

Please carry this Ack when you send v3.

Thanks.