netdev - Re: [Patch net 08/12] selftests/tc-testing: Add a test case for CODEL with HTB parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpW7f5QJRXBpEMAmMVNvF5aGk_2YNLVF=bcnoZhMhjDU4A@mail.gmail.com>
Date: Wed, 2 Apr 2025 17:40:38 -0700
From: Cong Wang <xiyou.wangcong@...il.com>
To: Victor Nogueira <victor@...atatu.com>
Cc: netdev@...r.kernel.org, jhs@...atatu.com, jiri@...nulli.us, 
	edumazet@...gle.com, gerrard.tai@...rlabs.sg, 
	Pedro Tammela <pctammela@...atatu.com>
Subject: Re: [Patch net 08/12] selftests/tc-testing: Add a test case for CODEL
 with HTB parent

On Sun, Mar 30, 2025 at 4:32 PM Cong Wang <xiyou.wangcong@...il.com> wrote:
>
> On Sun, Mar 30, 2025 at 06:05:06PM -0300, Victor Nogueira wrote:
> > On 28/03/2025 17:35, Cong Wang wrote:
> > > On Sun, Mar 23, 2025 at 07:48:39PM -0300, Victor Nogueira wrote:
> > > > On 20/03/2025 20:25, Cong Wang wrote:
> > > > > Add a test case for CODEL with HTB parent to verify packet drop
> > > > > behavior when the queue becomes empty. This helps ensure proper
> > > > > notification mechanisms between qdiscs.
> > > > >
> > > > > Note this is best-effort, it is hard to play with those parameters
> > > > > perfectly to always trigger ->qlen_notify().
> > > > >
> > > > > Cc: Pedro Tammela <pctammela@...atatu.com>
> > > > > Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>
> > > >
> > > > Cong, can you double check this test?
> > > > I ran all of your other tests and they all succeeded, however
> > > > this one specifically is always failing:
> > >
> > > Interesting, I thought I completely fixed this before posting after several
> > > rounds of playing with the parameters. I will double check it, maybe it
> > > just becomes less reproducible.
> >
> > I see.
> > I experimented with it a bit today and found out that changing the ping
> > command to:
> >
> > ping -c 2 -i 0 -s 1500 -I $DUMMY 10.10.10.1 > /dev/null || true
> >
> > makes the test pass consistently (at least in my environment).
> > So essentially just changing the "-s" option to 1500.
> >
> > If you could, please try it out as well.
> > Maybe I just got lucky.
>
> Sure, I will change it to 1500.

Hmm, it failed on my side:

Test a4bd: Test CODEL with HTB parent - force packet drop with empty queue

-----> prepare stage *** Could not execute: "ping -c 2 -i 0 -s 1500 -I
$DUMMY 10.10.10.1 > /dev/null || true"

-----> prepare stage *** Error message: "Command "/sbin/ip netns exec
tcut-3264298917 ping -c 2 -i 0 -s 1500 -I dummy1ida4bd 10.10.10.1 >
/dev/null || true" timed out
"
returncode 255; expected [0]