netdev - Re: [Intel-wired-lan] [PATCH iwl-next] ice: improve error message for insufficient filter space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <125533c8-44fe-4a87-af16-d934800b82d2@linux.intel.com>
Date: Thu, 3 Apr 2025 11:51:28 +0200
From: "Szapar-Mudlaw, Martyna" <martyna.szapar-mudlaw@...ux.intel.com>
To: "Buvaneswaran, Sujai" <sujai.buvaneswaran@...el.com>,
 Simon Horman <horms@...nel.org>
Cc: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next] ice: improve error message for
 insufficient filter space

Hi Sujai,

I reverified the issue, and with the patch, I am now getting the correct 
error about insufficient space, when attempting to add to many rules. 
The error you’re encountering might be caused by a different issue.

Could you please test it again or send me offline the set of rules you 
are adding? It seems to be working fine on my side.

Regards,
Martyna

On 4/1/2025 11:49 AM, Buvaneswaran, Sujai wrote:
> Hi,
> 
> I tried to add tc rules to the HW beyond the maximum limit and still noticing the below error message instead of error message mentioned in the patch.
> 
> [root@...l-cnv-sut ~]# tc filter add dev ens5f0np0 ingress protocol ip prio 0 flower skip_sw dst_mac 00:f0:01:00:00:0E action mirred egress redirect dev ens5f0npf0vf0
> Error: ice: Unable to add filter due to error.
> We have an error talking to the kernel
> 
> [root@...l-cnv-sut ~]# tc filter show dev ens5f0np0 root | grep -c in_hw
> 16306
> 
> Please check it.
> 
> Thanks,
> Sujai B
> 
>> -----Original Message-----
>> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
>> Simon Horman
>> Sent: Wednesday, March 19, 2025 5:48 PM
>> To: Martyna Szapar-Mudlaw <martyna.szapar-mudlaw@...ux.intel.com>
>> Cc: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; Michal
>> Swiatkowski <michal.swiatkowski@...ux.intel.com>
>> Subject: Re: [Intel-wired-lan] [PATCH iwl-next] ice: improve error message for
>> insufficient filter space
>>
>> On Fri, Mar 14, 2025 at 09:11:11AM +0100, Martyna Szapar-Mudlaw wrote:
>>> When adding a rule to switch through tc, if the operation fails due to
>>> not enough free recipes (-ENOSPC), provide a clearer error message:
>>> "Unable to add filter: insufficient space available."
>>>
>>> This improves user feedback by distinguishing space limitations from
>>> other generic failures.
>>>
>>> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
>>> Signed-off-by: Martyna Szapar-Mudlaw
>>> <martyna.szapar-mudlaw@...ux.intel.com>
>>
>> Reviewed-by: Simon Horman <horms@...nel.org>
> 
>