netdev - Re: [PATCH iwl-next v4 1/2] igc: Limit netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250407124741.GJ395307@horms.kernel.org>
Date: Mon, 7 Apr 2025 13:47:41 +0100
From: Simon Horman <horms@...nel.org>
To: Kurt Kanzenbach <kurt@...utronix.de>
Cc: Tony Nguyen <anthony.l.nguyen@...el.com>,
	Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	Faizal Rahim <faizal.abdul.rahim@...ux.intel.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org
Subject: Re: [PATCH iwl-next v4 1/2] igc: Limit netdev_tc calls to MQPRIO

On Fri, Mar 21, 2025 at 02:52:38PM +0100, Kurt Kanzenbach wrote:
> Limit netdev_tc calls to MQPRIO. Currently these calls are made in
> igc_tsn_enable_offload() and igc_tsn_disable_offload() which are used by
> TAPRIO and ETF as well. However, these are only required for MQPRIO.
> 
> Signed-off-by: Kurt Kanzenbach <kurt@...utronix.de>

Hi Kurt,

Thanks for the update. And I apologise that I now have question.

I see that:

* This patch moves logic from igc_tsn_disable_offload()
  and igc_tsn_enable_offload() to igc_tsn_enable_mqprio().

* That both igc_tsn_disable_offload() and igc_tsn_enable_offload()
  are only called from igc_tsn_reset().

* And that based on the description, this looks good for the case
  where igc_tsn_reset() is called from igc_tsn_offload_apply().
  This is because igc_tsn_offload_apply() is called from
  igc_tsn_enable_mqprio().

All good so far.

But my question is about the case where igc_tsn_reset() is called from
igc_reset(). Does the logic previously present in igc_tsn_enable_offload()
and igc_tsn_disable_offload() need to run in that case? And, if so,
how is that handled?