netdev - Re: [PATCH v2 net] net: Fix null-ptr-deref by sock_lock_init_class_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250407154623.15542-1-kuniyu@amazon.com>
Date: Mon, 7 Apr 2025 08:46:18 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <horms@...nel.org>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <ematsumiya@...e.de>,
	<kuba@...nel.org>, <kuni1840@...il.com>, <kuniyu@...zon.com>,
	<netdev@...r.kernel.org>, <pabeni@...hat.com>, <peterz@...radead.org>,
	<sfrench@...ba.org>, <stable@...r.kernel.org>, <wangzhaolong1@...wei.com>,
	<willemb@...gle.com>
Subject: Re: [PATCH v2 net] net: Fix null-ptr-deref by sock_lock_init_class_and_name() and rmmod.

From: Simon Horman <horms@...nel.org>
Date: Mon, 7 Apr 2025 11:45:59 +0100
> > diff --git a/include/net/sock.h b/include/net/sock.h
> > index 8daf1b3b12c6..4216d7d86150 100644
> > --- a/include/net/sock.h
> > +++ b/include/net/sock.h
> > @@ -547,6 +547,10 @@ struct sock {
> >  	struct rcu_head		sk_rcu;
> >  	netns_tracker		ns_tracker;
> >  	struct xarray		sk_user_frags;
> > +
> > +#if IS_ENABLED(CONFIG_PROVE_LOCKING) && IS_ENABLED(CONFIG_MODULES)
> > +	struct module		*sk_owner;
> > +#endif
> 
> Not a proper review, but FWIIW, sk_owner should be added to the Kernel doc
> for struct sock.

Thanks for catching!
Will add kdoc in v3.