netdev - Re: [PATCH iwl-net v2] ice: use DSN instead of PCI BDF for ice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <770a44c6-c808-4b31-aaa5-be8e57fbbf53@intel.com>
Date: Mon, 7 Apr 2025 10:15:28 -0700
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: Przemek Kitszel <przemyslaw.kitszel@...el.com>, Michal Kubiak
	<michal.kubiak@...el.com>
CC: <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>, Jacob Keller
	<jacob.e.keller@...el.com>, Jakub Kicinski <kuba@...nel.org>, Jiri Pirko
	<jiri@...nulli.us>, Aleksandr Loktionov <aleksandr.loktionov@...el.com>,
	Karol Kolacinski <karol.kolacinski@...el.com>, Grzegorz Nitka
	<grzegorz.nitka@...el.com>, Michal Schmidt <mschmidt@...hat.com>, "Sergey
 Temerkhanov" <sergey.temerkhanov@...el.com>
Subject: Re: [PATCH iwl-net v2] ice: use DSN instead of PCI BDF for
 ice_adapter index



On 4/7/2025 6:30 AM, Przemek Kitszel wrote:
> On 4/7/25 13:42, Michal Kubiak wrote:
>> On Mon, Apr 07, 2025 at 01:20:05PM +0200, Przemek Kitszel wrote:
>>> Use Device Serial Number instead of PCI bus/device/function for
>>> index of struct ice_adapter.
>>> Functions on the same physical device should point to the very same
>>> ice_adapter instance.
>>>
>>> This is not only simplification, but also fixes things up when PF
>>> is passed to VM (and thus has a random BDF).
>>>
>>> Suggested-by: Jacob Keller <jacob.e.keller@...el.com>
>>> Suggested-by: Jakub Kicinski <kuba@...nel.org>
>>> Suggested-by: Jiri Pirko <jiri@...nulli.us>
>>> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
>>> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
>>> ---
>>> CC: Karol Kolacinski <karol.kolacinski@...el.com>
>>> CC: Grzegorz Nitka <grzegorz.nitka@...el.com>
>>> CC: Michal Schmidt <mschmidt@...hat.com>
>>> CC: Sergey Temerkhanov <sergey.temerkhanov@...el.com>
>>>
>>> v2:
>>>   - target to -net (Jiri)
>>
>> Missing "Fixes" tag? (After retargetting to -net).
>>
>> Thanks,
>> Michal
> 
> oh, thanks, I wonder if our pw will pick the tag, if not, I will resend
> 
> Fixes: 0e2bddf9e5f9 ("ice: add ice_adapter for shared data across PFs on 
> the same NIC")

I don't believe it does, but I can add it in. No need to resend.

Thanks,
Tony