netdev - Re: [PATCH v1 net-next] net: ena: Support persistent per-NAPI config.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_QUx7c-7LxPEuor@LQ3V64L9R2>
Date: Mon, 7 Apr 2025 11:09:11 -0700
From: Joe Damato <jdamato@...tly.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: Shay Agroskin <shayagr@...zon.com>,
	Arthur Kiyanovski <akiyano@...zon.com>,
	David Arinzon <darinzon@...zon.com>,
	Saeed Bishara <saeedb@...zon.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net-next] net: ena: Support persistent per-NAPI config.

On Mon, Apr 07, 2025 at 09:47:59AM -0700, Kuniyuki Iwashima wrote:
> Let's pass the queue index to netif_napi_add_config() to preserve
> per-NAPI config.
> 
> Test:
> 
> Set 100 to defer-hard-irqs (default is 0) and check the value after
> link down & up.
> 
>   $ cat /sys/class/net/enp39s0/napi_defer_hard_irqs
>   0
> 
>   $ ./tools/net/ynl/pyynl/cli.py --spec Documentation/netlink/specs/netdev.yaml \
>     --dump napi-get --json='{"ifindex": 2}'
>   [{'defer-hard-irqs': 0,
>     'gro-flush-timeout': 0,
>     'id': 65,
>     'ifindex': 2,
>     'irq': 29,
>     'irq-suspend-timeout': 0}]
> 
>   $ sudo ./tools/net/ynl/pyynl/cli.py --spec Documentation/netlink/specs/netdev.yaml \
>     --do napi-set --json='{"id": 65, "defer-hard-irqs": 100}'
> 
>   $ sudo ip link set enp39s0 down && sudo ip link set enp39s0 up
> 
> Without patch:
> 
>   $ ./tools/net/ynl/pyynl/cli.py --spec Documentation/netlink/specs/netdev.yaml \
>     --dump napi-get --json='{"ifindex": 2}'
>   [{'defer-hard-irqs': 0,  <------------------- Reset to 0
>     'gro-flush-timeout': 0,
>     'id': 66,  <------------------------------- New ID
>     'ifindex': 2,
>     'irq': 29,
>     'irq-suspend-timeout': 0}]
> 
> With patch:
> 
>   $ ./tools/net/ynl/pyynl/cli.py --spec Documentation/netlink/specs/netdev.yaml \
>     --dump napi-get --json='{"ifindex": 2}'
>   [{'defer-hard-irqs': 100,  <--------------+-- Preserved
>     'gro-flush-timeout': 0,                 |
>     'id': 65,  <----------------------------'
>     'ifindex': 2,
>     'irq': 29,
>     'irq-suspend-timeout': 0}]
> 
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>
> ---
>  drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thank you for adding support for this!

Reviewed-by: Joe Damato <jdamato@...tly.com>