netdev - Re: [PATCH net-next 2/2] net: stmmac: dwc-qos: use stmmac_pltfr_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+V-a8t=V-EB4r_vBBSJfmAx1_tBRsvV-m3wM841fAw75-ueZA@mail.gmail.com>
Date: Mon, 7 Apr 2025 20:33:50 +0100
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, 
	Alexandre Torgue <alexandre.torgue@...s.st.com>, Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Jon Hunter <jonathanh@...dia.com>, 
	linux-arm-kernel@...ts.infradead.org, 
	linux-stm32@...md-mailman.stormreply.com, 
	Maxime Coquelin <mcoquelin.stm32@...il.com>, netdev@...r.kernel.org, 
	Paolo Abeni <pabeni@...hat.com>, Thierry Reding <treding@...dia.com>
Subject: Re: [PATCH net-next 2/2] net: stmmac: dwc-qos: use stmmac_pltfr_find_clk()

On Mon, Apr 7, 2025 at 7:39 PM Russell King (Oracle)
<rmk+kernel@...linux.org.uk> wrote:
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> ---
>  .../ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c    | 14 ++------------
>  1 file changed, 2 insertions(+), 12 deletions(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>

Cheers,
Prabhakar

> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c
> index cd431f84f34f..f5c68e3b4354 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c
> @@ -34,16 +34,6 @@ struct tegra_eqos {
>         struct gpio_desc *reset;
>  };
>
> -static struct clk *dwc_eth_find_clk(struct plat_stmmacenet_data *plat_dat,
> -                                   const char *name)
> -{
> -       for (int i = 0; i < plat_dat->num_clks; i++)
> -               if (strcmp(plat_dat->clks[i].id, name) == 0)
> -                       return plat_dat->clks[i].clk;
> -
> -       return NULL;
> -}
> -
>  static int dwc_eth_dwmac_config_dt(struct platform_device *pdev,
>                                    struct plat_stmmacenet_data *plat_dat)
>  {
> @@ -132,7 +122,7 @@ static int dwc_qos_probe(struct platform_device *pdev,
>                          struct plat_stmmacenet_data *plat_dat,
>                          struct stmmac_resources *stmmac_res)
>  {
> -       plat_dat->pclk = dwc_eth_find_clk(plat_dat, "phy_ref_clk");
> +       plat_dat->pclk = stmmac_pltfr_find_clk(plat_dat, "phy_ref_clk");
>
>         return 0;
>  }
> @@ -242,7 +232,7 @@ static int tegra_eqos_probe(struct platform_device *pdev,
>         if (!is_of_node(dev->fwnode))
>                 goto bypass_clk_reset_gpio;
>
> -       plat_dat->clk_tx_i = dwc_eth_find_clk(plat_dat, "tx");
> +       plat_dat->clk_tx_i = stmmac_pltfr_find_clk(plat_dat, "tx");
>
>         eqos->reset = devm_gpiod_get(&pdev->dev, "phy-reset", GPIOD_OUT_HIGH);
>         if (IS_ERR(eqos->reset)) {
> --
> 2.30.2
>