netdev - Re: [PATCH net-next v6] net: dlink: add support for reporting stats via `ethtool -S` and `ip -s -s link show`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_RYc2R_Qf0xCaLv@mythos-cloud>
Date: Tue, 8 Apr 2025 07:57:55 +0900
From: Moon Yeounsu <yyyynoom@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v6] net: dlink: add support for reporting stats
 via `ethtool -S` and `ip -s -s link show`

On Mon, Apr 07, 2025 at 10:48:01PM +0200, Andrew Lunn wrote:
> When i see a list like this, it makes me think this should be broken
> up into multiple patches. Ideally you want lots of simple patches
> which are obviously correct.

Would it be appropriate to split this into a patchset, then?
To be honest, this is my first time creating a patchset, so
I'm not entirely sure how to divide it properly.

For now, I'm thinking of splitting it as follows:
	1. stat definitions and declarations
	2. preprocessor directives (`#ifdef`)
	3. `spin_[un]lock_irq()` related changes
	4. `get_stats()` implementation
	5. `ethtool_ops` implementation

Is it okay to resend the v7 patchset split as above?