netdev - Re: [PATCH net] tc: Ensure we have enough buffer space when sending filter netlink notifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <126fa7e1-dbe0-48ff-9cb5-31c1d4dea964@redhat.com>
Date: Tue, 8 Apr 2025 13:57:29 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Toke Høiland-Jørgensen <toke@...hat.com>,
 Jamal Hadi Salim <jhs@...atatu.com>, Cong Wang <xiyou.wangcong@...il.com>,
 Jiri Pirko <jiri@...nulli.us>
Cc: Ilya Maximets <i.maximets@...hat.com>,
 Frode Nordahl <frode.nordahl@...onical.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Simon Horman <horms@...nel.org>,
 netdev@...r.kernel.org
Subject: Re: [PATCH net] tc: Ensure we have enough buffer space when sending
 filter netlink notifications

On 4/7/25 12:55 PM, Toke Høiland-Jørgensen wrote:
> To trigger this, run the following commands:
> 
>  # ip link add type veth
>  # tc qdisc replace dev veth0 root handle 1: fq_codel
>  # tc -echo filter add dev veth0 parent 1: u32 match u32 0 0 $(for i in $(seq 32); do echo action pedit munge ip dport set 22; done)
> 
> Before this fix, tc just returns:
> 
> Not a filter(cmd 2)
> 
> After the fix, we get the correct echo:
> 
> added filter dev veth0 parent 1: protocol all pref 49152 u32 chain 0 fh 800::800 order 2048 key ht 800 bkt 0 terminal flowid not_in_hw
>   match 00000000/00000000 at 0
> 	action order 1:  pedit action pass keys 1
>  	index 1 ref 1 bind 1
> 	key #0  at 20: val 00000016 mask ffff0000
> [repeated 32 times]

I think it would be great if you could follow-up capturing the above in
a self-test.

Thanks!

Paolo