netdev - Re: [PATCH net] ipv6: Align behavior across nexthops during path selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67f52c6843f94_34067294be@willemb.c.googlers.com.notmuch>
Date: Tue, 08 Apr 2025 10:02:16 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Ido Schimmel <idosch@...dia.com>, 
 netdev@...r.kernel.org
Cc: davem@...emloft.net, 
 kuba@...nel.org, 
 pabeni@...hat.com, 
 edumazet@...gle.com, 
 dsahern@...nel.org, 
 horms@...nel.org, 
 willemdebruijn.kernel@...il.com, 
 Ido Schimmel <idosch@...dia.com>
Subject: Re: [PATCH net] ipv6: Align behavior across nexthops during path
 selection

Ido Schimmel wrote:
> A nexthop is only chosen when the calculated multipath hash falls in the
> nexthop's hash region (i.e., the hash is smaller than the nexthop's hash
> threshold) and when the nexthop is assigned a non-negative score by
> rt6_score_route().
> 
> Commit 4d0ab3a6885e ("ipv6: Start path selection from the first
> nexthop") introduced an unintentional difference between the first
> nexthop and the rest when the score is negative.
> 
> When the first nexthop matches, but has a negative score, the code will
> currently evaluate subsequent nexthops until one is found with a
> non-negative score. On the other hand, when a different nexthop matches,
> but has a negative score, the code will fallback to the nexthop with
> which the selection started ('match').
> 
> Align the behavior across all nexthops and fallback to 'match' when the
> first nexthop matches, but has a negative score.
> 
> Fixes: 3d709f69a3e7 ("ipv6: Use hash-threshold instead of modulo-N")
> Fixes: 4d0ab3a6885e ("ipv6: Start path selection from the first nexthop")
> Reported-by: Willem de Bruijn <willemdebruijn.kernel@...il.com>
> Closes: https://lore.kernel.org/netdev/67efef607bc41_1ddca82948c@willemb.c.googlers.com.notmuch/
> Signed-off-by: Ido Schimmel <idosch@...dia.com>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>