netdev - Re: [Intel-wired-lan] [PATCH 1/2] ethtool: transceiver reset and presence pin control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250408155844.30790-1-mpazdan@arista.com>
Date: Tue,  8 Apr 2025 15:54:14 +0000
From: Marek Pazdan <mpazdan@...sta.com>
To: kory.maincent@...tlin.com
Cc: aleksander.lobakin@...el.com,
	almasrymina@...gle.com,
	andrew+netdev@...n.ch,
	anthony.l.nguyen@...el.com,
	daniel.zahka@...il.com,
	davem@...emloft.net,
	ecree.xilinx@...il.com,
	edumazet@...gle.com,
	gal@...dia.com,
	horms@...nel.org,
	intel-wired-lan@...ts.osuosl.org,
	jianbol@...dia.com,
	kuba@...nel.org,
	linux-kernel@...r.kernel.org,
	mpazdan@...sta.com,
	netdev@...r.kernel.org,
	pabeni@...hat.com,
	przemyslaw.kitszel@...el.com,
	willemb@...gle.com
Subject: Re: [Intel-wired-lan] [PATCH 1/2] ethtool: transceiver reset and presence pin control

On  Mon, 7 Apr 2025 15:32:03 +0200 Kory Maincent wrote:
> ETHTOOL_PHY_G/STUNABLE IOCTLs are targeting the PHY of the NIC but IIUC in your
> case you are targeting the reset of the QSFP module. Maybe phylink API is more
> appropriate for this feature.
> 
> You have to add net-next prefix in the subject like this [PATCH net-next 1/2]
> when you add new support to net subsystem.

Thanks for review.
>From up to now replies I see that there are concerns regarding usage phy-tunable ethtool
option for this purpose, so I will post updated patches after we clarify proper way to go. 
I need to check more on phylink API, from the overview I read:
"phylink is a mechanism to support hot-pluggable networking modules directly connected
to a MAC without needing to re-initialise the adapter on hot-plug events.

phylink supports conventional phylib-based setups, fixed link setups
and SFP (Small Formfactor Pluggable) modules at present."

I don't see QSFP modules are being supported but I need to verify impact of this.
As I mentioned in other reply this API should allow for transceiver module reset 
from user space if orchestration agent detects transceiver failure state or when
it gets direct request from Cli.