netdev - Re: [PATCH net-next 2/5] eth: fbnic: add coverage for hw queue stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250408164053.GB395307@horms.kernel.org>
Date: Tue, 8 Apr 2025 17:40:53 +0100
From: Simon Horman <horms@...nel.org>
To: Mohsin Bashir <mohsin.bashr@...il.com>
Cc: netdev@...r.kernel.org, alexanderduyck@...com, kuba@...nel.org,
	andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	pabeni@...hat.com, suhui@...china.com, sanman.p211993@...il.com,
	vadim.fedorenko@...ux.dev, kalesh-anakkur.purayil@...adcom.com,
	kernel-team@...a.com
Subject: Re: [PATCH net-next 2/5] eth: fbnic: add coverage for hw queue stats

On Mon, Apr 07, 2025 at 10:21:48AM -0700, Mohsin Bashir wrote:
> This patch provides support for hardware queue stats and covers
> packet errors for RX-DMA engine, RCQ drops and BDQ drops.
> 
> The packet errors are also aggregated with the `rx_errors` stats in the
> `rtnl_link_stats` as well as with the `hw_drops` in the queue API.
> 
> The RCQ and BDQ drops are aggregated with `rx_over_errors` in the
> `rtnl_link_stats` as well as with the `hw_drop_overruns` in the queue API.
> 
> ethtool -S eth0 | grep -E 'rde'
>      rde_0_pkt_err: 0
>      rde_0_pkt_cq_drop: 0
>      rde_0_pkt_bdq_drop: 0
>      ---
>      ---
>      rde_127_pkt_err: 0
>      rde_127_pkt_cq_drop: 0
>      rde_127_pkt_bdq_drop: 0
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> Signed-off-by: Mohsin Bashir <mohsin.bashr@...il.com>

Reviewed-by: Simon Horman <horms@...nel.org>