netdev - Re: [PATCH net-next 1/5] eth: fbnic: add locking support for hw stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250408164038.GA395307@horms.kernel.org>
Date: Tue, 8 Apr 2025 17:40:38 +0100
From: Simon Horman <horms@...nel.org>
To: Mohsin Bashir <mohsin.bashr@...il.com>
Cc: netdev@...r.kernel.org, alexanderduyck@...com, kuba@...nel.org,
	andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	pabeni@...hat.com, suhui@...china.com, sanman.p211993@...il.com,
	vadim.fedorenko@...ux.dev, kalesh-anakkur.purayil@...adcom.com,
	kernel-team@...a.com
Subject: Re: [PATCH net-next 1/5] eth: fbnic: add locking support for hw stats

On Mon, Apr 07, 2025 at 10:21:47AM -0700, Mohsin Bashir wrote:
> This patch adds lock protection for the hardware statistics for fbnic.
> The hardware statistics access via ndo_get_stats64 is not protected by
> the rtnl_lock(). Since these stats can be accessed from different places
> in the code such as service task, ethtool, Q-API, and net_device_ops, a
> lock-less approach can lead to races.
> 
> Note that this patch is not a fix rather, just a prep for the subsequent
> changes in this series.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> Signed-off-by: Mohsin Bashir <mohsin.bashr@...il.com>

Reviewed-by: Simon Horman <horms@...nel.org>