netdev - Re: [PATCH net-next v2 3/3] net: phy: dp83822: Add support for changing the MAC termination

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250408171831.GA4828@debian>
Date: Tue, 8 Apr 2025 19:18:31 +0200
From: Dimitri Fedrau <dima.fedrau@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: "Fedrau Dimitri (LED)" <Dimitri.Fedrau@...bherr.com>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Florian Fainelli <f.fainelli@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2 3/3] net: phy: dp83822: Add support for
 changing the MAC termination

On Tue, Apr 08, 2025 at 03:28:32PM +0200, Andrew Lunn wrote:
> On Tue, Apr 08, 2025 at 01:01:17PM +0000, Fedrau Dimitri (LED) wrote:
> > -----Ursprüngliche Nachricht-----
> > Von: Andrew Lunn <andrew@...n.ch> 
> > Gesendet: Dienstag, 8. April 2025 14:47
> > An: Fedrau Dimitri (LED) <dimitri.fedrau@...bherr.com>
> > Cc: Heiner Kallweit <hkallweit1@...il.com>; Russell King <linux@...linux.org.uk>; David S. Miller <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; Rob Herring <robh@...nel.org>; Krzysztof Kozlowski <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>; Florian Fainelli <f.fainelli@...il.com>; netdev@...r.kernel.org; devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; Dimitri Fedrau <dima.fedrau@...il.com>
> > Betreff: Re: [PATCH net-next v2 3/3] net: phy: dp83822: Add support for changing the MAC termination
> > 
> > > > +static const u32 mac_termination[] = {
> > > > +	99, 91, 84, 78, 73, 69, 65, 61, 58, 55, 53, 50, 48, 46, 44, 43,
> > > 
> > > Please add this list to the binding.
> > 
> > Add this list to "ti,dp83822.yaml" ?
> 
> Yes please. Ideally we want the DT validation tools to pick up invalid
> values before they reach the kernel.
>
Ok, but then I would have to add "mac-termination-ohms" property to
"ti,dp83822.yaml" as well together with the allowed values ? Ending up in
some sort of duplication, because the property is already defined in
"ethernet-phy.yaml". Is this the right way to do it ?

Best regards,
Dimitri Fedrau