netdev - Re: [PATCH net-next 01/15] devlink: add value check to devlink_info_version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9638476-1778-4e34-96ac-448d12877702@amd.com>
Date: Mon, 7 Apr 2025 17:31:18 -0700
From: "Nelson, Shannon" <shannon.nelson@....com>
To: Tony Nguyen <anthony.l.nguyen@...el.com>, davem@...emloft.net,
 kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com,
 andrew+netdev@...n.ch, netdev@...r.kernel.org
Cc: Jedrzej Jagielski <jedrzej.jagielski@...el.com>,
 przemyslaw.kitszel@...el.com, jiri@...nulli.us, horms@...nel.org,
 corbet@....net, linux-doc@...r.kernel.org,
 Kalesh AP <kalesh-anakkur.purayil@...adcom.com>,
 Bharath R <bharath.r@...el.com>
Subject: Re: [PATCH net-next 01/15] devlink: add value check to
 devlink_info_version_put()

On 4/7/2025 2:51 PM, Tony Nguyen wrote:
> From: Jedrzej Jagielski <jedrzej.jagielski@...el.com>
> 
> Prevent from proceeding if there's nothing to print.
> 
> Suggested-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Reviewed-by: Jiri Pirko <jiri@...dia.com>
> Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@...adcom.com>
> Tested-by: Bharath R <bharath.r@...el.com>
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@...el.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>
> ---
>   net/devlink/dev.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/devlink/dev.c b/net/devlink/dev.c
> index d6e3db300acb..02602704bdea 100644
> --- a/net/devlink/dev.c
> +++ b/net/devlink/dev.c
> @@ -775,7 +775,7 @@ static int devlink_info_version_put(struct devlink_info_req *req, int attr,
>                  req->version_cb(version_name, version_type,
>                                  req->version_cb_priv);
> 
> -       if (!req->msg)
> +       if (!req->msg || !*version_value)

Personally, I'd like to know that the value was blank if there was 
normally a value to be printed.  This is removing a useful indicator of 
something that might be wrong.

sln

>                  return 0;
> 
>          nest = nla_nest_start_noflag(req->msg, attr);
> --
> 2.47.1
> 
>