netdev - Re: [PATCH net-next v8 1/2] page_pool: Move pp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250408121352.6a2349a9@kernel.org>
Date: Tue, 8 Apr 2025 12:13:52 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Toke Høiland-Jørgensen <toke@...hat.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jesper Dangaard Brouer
 <hawk@...nel.org>, Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky
 <leon@...nel.org>, Tariq Toukan <tariqt@...dia.com>, Andrew Lunn
 <andrew+netdev@...n.ch>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Ilias Apalodimas <ilias.apalodimas@...aro.org>, Simon
 Horman <horms@...nel.org>, Andrew Morton <akpm@...ux-foundation.org>, Mina
 Almasry <almasrymina@...gle.com>, Yonglong Liu <liuyonglong@...wei.com>,
 Yunsheng Lin <linyunsheng@...wei.com>, Pavel Begunkov
 <asml.silence@...il.com>, Matthew Wilcox <willy@...radead.org>,
 netdev@...r.kernel.org, bpf@...r.kernel.org, linux-rdma@...r.kernel.org,
 linux-mm@...ck.org
Subject: Re: [PATCH net-next v8 1/2] page_pool: Move pp_magic check into
 helper functions

On Mon, 07 Apr 2025 18:53:28 +0200 Toke Høiland-Jørgensen wrote:
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index b7f13f087954bdccfe1e263d39a59bfd1d738ab6..6f9ef1634f75701ae0be146add1ea2c11beb6e48 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -4248,4 +4248,25 @@ int arch_lock_shadow_stack_status(struct task_struct *t, unsigned long 

> +static inline bool page_pool_page_is_pp(struct page *page)
> +{
> +	return false;
> +}
> +#endif
> +
> +

extra empty line here

>  #endif /* _LINUX_MM_H */
> diff --git a/include/net/page_pool/types.h b/include/net/page_pool/types.h
> index 36eb57d73abc6cfc601e700ca08be20fb8281055..31e6c5c6724b1cffbf5ad2535b3eaee5dec54d9d 100644
> --- a/include/net/page_pool/types.h
> +++ b/include/net/page_pool/types.h
> @@ -264,6 +264,7 @@ void page_pool_destroy(struct page_pool *pool);
>  void page_pool_use_xdp_mem(struct page_pool *pool, void (*disconnect)(void *),
>  			   const struct xdp_mem_info *mem);
>  void page_pool_put_netmem_bulk(netmem_ref *data, u32 count);
> +

and here

>  #else
>  static inline void page_pool_destroy(struct page_pool *pool)
>  {
-- 
pw-bot: cr