netdev - Re: [PATCH net-next v25 00/23] Introducing OpenVPN Data Channel Offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bff01a88-1e5d-4855-b7d9-1b1ac4bed650@kernel.org>
Date: Tue, 8 Apr 2025 08:34:27 +0200
From: Jiri Slaby <jirislaby@...nel.org>
To: Antonio Quartulli <antonio@...nvpn.net>, netdev@...r.kernel.org,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Donald Hunter <donald.hunter@...il.com>,
 Shuah Khan <shuah@...nel.org>, sd@...asysnail.net, ryazanov.s.a@...il.com,
 Andrew Lunn <andrew+netdev@...n.ch>
Cc: Simon Horman <horms@...nel.org>, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org, Xiao Liang <shaw.leon@...il.com>,
 steffen.klassert@...unet.com, antony.antony@...unet.com,
 willemdebruijn.kernel@...il.com, David Ahern <dsahern@...nel.org>,
 Andrew Lunn <andrew@...n.ch>, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH net-next v25 00/23] Introducing OpenVPN Data Channel
 Offload

On 07. 04. 25, 21:46, Antonio Quartulli wrote:
> Notable changes since v24:
> * disable TCP disconnections of attached sockets (tcp_disconnect()
>    returns -EBUSY) - similarly to kTLS.
> * used rcu_replace_pointer instead of rcu_dereference_protected+rcu_assign_pointer
> * dropped useless skb->ignore_df = 1
> * dropped unneded EXPORT_SYMBOL_GPL(udpv6_prot)
> * dropped obsolete comment for ovpn_crypto_key_slots_swap()
> * dropped calls to kfree() in ovpn_aead_encrypt/decrypt() (release is
>    performed in ovpn_encrypt/decrypt_post())
> * dropped NULL check before calling kfree() in
>    ovpn_encrypt/decrypt_done()
> * converted seq_num from atomic64_t to atomic_t (IV exhaustion is now
>    detected in case of wrap around)
> * call consume_skb() on skb when dropping keepalive message (it is not a
>    failure)
> * made REMOTE_PORT mandatory when REMOTE_IPV4/6 is specified in
>    peer_new/set call
> * ensured ovpn_nl_key_swap_notify() is called only once, even when
>    parsing a batch of received packets concurrently
> 
> Please note that some patches were already reviewed/tested by a few
> people. These patches have retained the tags as they have hardly been
> touched.
> 
> The latest code can also be found at:
> 
> https://github.com/OpenVPN/ovpn-net-next

Given:
 > +#define OVPN_FAMILY_NAME	"ovpn"
and
 > ctx->ovpn_dco_id = genl_ctrl_resolve(ctx->nl_sock, OVPN_FAMILY_NAME);

Is there also an openvpn branch understanding the new (in-kernel) 
naming? I.e. something like s/ovpn-dco-v2/ovpn/?

As with 2.6.10, I see:
$ grep -iE 'offl|dco' log
2025-04-08 08:24:59 us=718854 Note: Kernel support for ovpn-dco missing, 
disabling data channel offload.
2025-04-08 08:24:59 us=719060 OpenVPN 2.6.10 x86_64-suse-linux-gnu [SSL 
(OpenSSL)] [LZO] [LZ4] [EPOLL] [PKCS11] [MH/PKTINFO] [AEAD] [DCO]
2025-04-08 08:24:59 us=719110 DCO version: N/A

thanks,
-- 
js
suse labs