netdev - Re: [PATCH net-next v3 2/2] trace: tcp: Add tracepoint for tcp_sendmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fcf2d508-d44e-43c3-b381-8f33fec11859@kernel.org>
Date: Tue, 8 Apr 2025 13:32:32 -0600
From: David Ahern <dsahern@...nel.org>
To: Breno Leitao <leitao@...ian.org>, Eric Dumazet <edumazet@...gle.com>,
 Neal Cardwell <ncardwell@...gle.com>, Kuniyuki Iwashima <kuniyu@...zon.com>,
 Steven Rostedt <rostedt@...dmis.org>, Masami Hiramatsu
 <mhiramat@...nel.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>
Cc: Song Liu <song@...nel.org>, Yonghong Song <yonghong.song@...ux.dev>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org, kernel-team@...a.com
Subject: Re: [PATCH net-next v3 2/2] trace: tcp: Add tracepoint for
 tcp_sendmsg_locked()

On 4/8/25 12:32 PM, Breno Leitao wrote:
> Add a tracepoint to monitor TCP send operations, enabling detailed
> visibility into TCP message transmission.
> 
> Create a new tracepoint within the tcp_sendmsg_locked function,
> capturing traditional fields along with size_goal, which indicates the
> optimal data size for a single TCP segment. Additionally, a reference to
> the struct sock sk is passed, allowing direct access for BPF programs.
> The implementation is largely based on David's patch[1] and suggestions.
> 
> Link: https://lore.kernel.org/all/70168c8f-bf52-4279-b4c4-be64527aa1ac@kernel.org/ [1]
> Signed-off-by: Breno Leitao <leitao@...ian.org>
> ---
>  include/trace/events/tcp.h | 24 ++++++++++++++++++++++++
>  kernel/bpf/btf.c           |  1 +
>  net/ipv4/tcp.c             |  2 ++
>  3 files changed, 27 insertions(+)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>