netdev - Re: [PATCH net v3] ipv6: sit: fix skb_under_panic with overflowed needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bfa5e258-fcca-4bb8-b5e9-50ba8e7fa249@huawei.com>
Date: Tue, 8 Apr 2025 15:49:09 +0800
From: Wang Liang <wangliang74@...wei.com>
To: Paolo Abeni <pabeni@...hat.com>, <davem@...emloft.net>,
	<dsahern@...nel.org>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<horms@...nel.org>, <kuniyu@...zon.com>
CC: <yuehaibing@...wei.com>, <zhangchangzhong@...wei.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net v3] ipv6: sit: fix skb_under_panic with overflowed
 needed_headroom


在 2025/4/3 19:50, Paolo Abeni 写道:
> On 4/1/25 4:16 AM, Wang Liang wrote:
>> @@ -1452,7 +1457,9 @@ static int ipip6_tunnel_init(struct net_device *dev)
>>   	tunnel->dev = dev;
>>   	strcpy(tunnel->parms.name, dev->name);
>>   
>> -	ipip6_tunnel_bind_dev(dev);
>> +	err = ipip6_tunnel_bind_dev(dev);
>> +	if (err)
>> +		return err;
>>   
>>   	err = dst_cache_init(&tunnel->dst_cache, GFP_KERNEL);
>>   	if (err)
> I think you additionally need to propagate the error in
> ipip6_tunnel_update() and handle it in ipip6_changelink() and
> ipip6_tunnel_change().


Thanks，I will add it in next patch.

>
> Side note: possibly other virtual devices are prone to similar issue. I
> suspect vxlan and gre. Could you please have a look?


Ok, I will try to reproduce the issue in vxvlan/gre scene later.

> Thanks,
>
> Paolo
>
>