netdev - Re: batman-adv: Fix double-hold of meshif when getting enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6178198.MhkbZ0Pkbq@ripper>
Date: Wed, 09 Apr 2025 09:30:52 +0200
From: Sven Eckelmann <sven@...fation.org>
To: netdev@...r.kernel.org
Cc: "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Subject: Re: batman-adv: Fix double-hold of meshif when getting enabled

On Wednesday, 9 April 2025 09:30:00 CEST Sven Eckelmann wrote:
> Fixes: 00b35530811f ("batman-adv: adopt netdev_hold() / netdev_put()")
> Signed-off-by: Sven Eckelmann <sven@...fation.org>
> 
> diff --git a/net/batman-adv/hard-interface.c b/net/batman-adv/hard-interface.c
> index f145f96626531053bbf8f58a31f28f625a9d80f9..7cd4bdcee43935b9e5fb7d1696430909b7af67b4 100644
> --- a/net/batman-adv/hard-interface.c
> +++ b/net/batman-adv/hard-interface.c
> @@ -725,7 +725,6 @@ int batadv_hardif_enable_interface(struct batadv_hard_iface *hard_iface,
>  
>  	kref_get(&hard_iface->refcount);
>  
> -	dev_hold(mesh_iface);
>  	netdev_hold(mesh_iface, &hard_iface->meshif_dev_tracker, GFP_ATOMIC);
>  	hard_iface->mesh_iface = mesh_iface;
>  	bat_priv = netdev_priv(hard_iface->mesh_iface);
> 

Sorry, from wrong folder
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)