netdev - Re: [PATCH net-next v2 2/2] net: phy: Add Marvell PHY PTP support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250409104858.2758e68e@kmaincent-XPS-13-7390>
Date: Wed, 9 Apr 2025 10:48:58 +0200
From: Kory Maincent <kory.maincent@...tlin.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Simon Horman <horms@...nel.org>, Andrew Lunn <andrew@...n.ch>, Heiner
 Kallweit <hkallweit1@...il.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, Marek Behún <kabel@...nel.org>,
 Richard Cochran <richardcochran@...il.com>, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>, Maxime Chevallier
 <maxime.chevallier@...tlin.com>, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 2/2] net: phy: Add Marvell PHY PTP support

On Wed, 9 Apr 2025 09:33:09 +0100
"Russell King (Oracle)" <linux@...linux.org.uk> wrote:

> On Wed, Apr 09, 2025 at 10:18:08AM +0200, Kory Maincent wrote:
> > On Tue, 8 Apr 2025 18:32:04 +0100
> > "Russell King (Oracle)" <linux@...linux.org.uk> wrote:
> >   
> > > On Tue, Apr 08, 2025 at 04:49:34PM +0100, Simon Horman wrote:  
>  [...]  
>  [...]  
>  [...]  
>  [...]  
>  [...]  
> > > 
> > > ... and anyway, I haven't dropped my patches, I'm waiting for the
> > > fundamental issue with merging Marvell PHY PTP support destroying the
> > > ability to use MVPP2 PTP support to be solved, and then I will post
> > > my patches.
> > > 
> > > They aren't dead, I'm just waiting for the issues I reported years ago
> > > with the PTP infrastructure to be resolved - and to be tested as
> > > resolved.
> > > 
> > > I'm still not convinced that they have been given Kory's responses to
> > > me (some of which I honestly don't understand), but I will get around
> > > to doing further testing to see whether enabling Marvell PHY PTP
> > > support results in MVPP2 support becoming unusable.
> > > 
> > > Kory's lack of communication with me has been rather frustrating.  
> > 
> > You were in CC in all the series I sent and there was not a lot of review
> > and testing on your side. I know you seemed a lot busy at that time but I
> > don't understand what communication is missing here?   
> 
> I don't spend much time at the physical location where the hardware that
> I need to test your long awaited code is anymore. That means the
> opportunities to test it are *rare*.
> 
> So far, each time I've tested your code, it's been broken. This really
> doesn't help.
> 
> If you want me to do anything more in a timely manner, like test fixes,
> you need to get them to me by the end of this week, otherwise I won't
> again be able to test them for a while.

You could try again with Vlad patch adding support to ndo_hwtstamp_get/set to
the mvpp2 drivers.
https://github.com/vladimiroltean/linux/commit/5bde95816f19cf2872367ecdbef1efe476e4f833

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com