netdev - Re: [PATCH net-next v4 05/11] net: ti: prueth: Adds ethtool support for ICSSM PRUETH Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <190529030.1024806.1744198410980.JavaMail.zimbra@couthit.local>
Date: Wed, 9 Apr 2025 17:03:30 +0530 (IST)
From: Parvathi Pudi <parvathi@...thit.com>
To: jacob e keller <jacob.e.keller@...el.com>
Cc: Andrew Lunn <andrew@...n.ch>, parvathi <parvathi@...thit.com>, 
	danishanwar <danishanwar@...com>, rogerq <rogerq@...nel.org>, 
	andrew+netdev <andrew+netdev@...n.ch>, davem <davem@...emloft.net>, 
	edumazet <edumazet@...gle.com>, kuba <kuba@...nel.org>, 
	pabeni <pabeni@...hat.com>, robh <robh@...nel.org>, 
	krzk+dt <krzk+dt@...nel.org>, conor+dt <conor+dt@...nel.org>, 
	nm <nm@...com>, ssantosh <ssantosh@...nel.org>, tony@...mide.com, 
	richardcochran <richardcochran@...il.com>, glaroque@...libre.com, 
	schnelle <schnelle@...ux.ibm.com>, 
	m-karicheri2 <m-karicheri2@...com>, rdunlap@...radead.org, 
	diogo ivo <diogo.ivo@...mens.com>, basharath <basharath@...thit.com>, 
	horms <horms@...nel.org>, m-malladi <m-malladi@...com>, 
	javier carrasco cruz <javier.carrasco.cruz@...il.com>, 
	afd <afd@...com>, s-anna <s-anna@...com>, 
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, 
	netdev <netdev@...r.kernel.org>, 
	devicetree <devicetree@...r.kernel.org>, 
	linux-kernel <linux-kernel@...r.kernel.org>, 
	linux-omap@...r.kernel.org, pratheesh <pratheesh@...com>, 
	Prajith Jayarajan <prajith@...com>, 
	Vignesh Raghavendra <vigneshr@...com>, praneeth <praneeth@...com>, 
	srk <srk@...com>, rogerq <rogerq@...com>, 
	krishna <krishna@...thit.com>, pmohan <pmohan@...thit.com>, 
	mohan <mohan@...thit.com>
Subject: Re: [PATCH net-next v4 05/11] net: ti: prueth: Adds ethtool support
 for ICSSM PRUETH Driver

Hi,

>> > +#define PRUETH_MODULE_VERSION "0.2"
>> 
>> > +static void icssm_emac_get_drvinfo(struct net_device *ndev,
>> > +				   struct ethtool_drvinfo *info)
>> > +{
>> > +	strscpy(info->driver, PRUETH_MODULE_DESCRIPTION, sizeof(info-
>> >driver));
>> > +	strscpy(info->version, PRUETH_MODULE_VERSION, sizeof(info->version));
>> 
>> Driver version numbers are pointless, they never change, but the
>> kernel is changing all the time. Leave version blank, and the core
>> will fill in the kernel version, which is useful.
>> 
>>      Andrew
> 
> It is also a long standing policy that in-tree drivers should not have versions
> separate from the kernel version.
> 

Ok. We will leave the version field blank as suggested by Andrew and cleanup version
will be resubmitted shortly.


Thanks and Regards,
Parvathi.