netdev - Re: [PATCH net-next v2 0/2] Add L2 hw acceleration for airoha

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z/Zg9XXuU0hpmGeO@localhost.localdomain>
Date: Wed, 9 Apr 2025 13:58:45 +0200
From: Michal Kubiak <michal.kubiak@...el.com>
To: Lorenzo Bianconi <lorenzo@...nel.org>
CC: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-mediatek@...ts.infradead.org>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2 0/2] Add L2 hw acceleration for airoha_eth
 driver

On Wed, Apr 09, 2025 at 11:47:13AM +0200, Lorenzo Bianconi wrote:
> Introduce the capability to offload L2 traffic defining flower rules in
> the PSE/PPE engine available on EN7581 SoC.
> Since the hw always reports L2/L3/L4 flower rules, link all L2 rules
> sharing the same L2 info (with different L3/L4 info) in the L2 subflows
> list of a given L2 PPE entry.
> 
> ---
> Changes in v2:
> - squash patch 1/3 and 2/3
> - explicitly initialize airoha_flow_table_entry type for
>   FLOW_TYPE_L4 entry
> - get rid of airoha_ppe_foe_flow_remove_entry_locked() and just rely on
>   airoha_ppe_foe_flow_remove_entry()
> - Link to v1: https://lore.kernel.org/r/20250407-airoha-flowtable-l2b-v1-0-18777778e568@kernel.org
> 
> ---
> Lorenzo Bianconi (2):
>       net: airoha: Add l2_flows rhashtable
>       net: airoha: Add L2 hw acceleration support
> 
>  drivers/net/ethernet/airoha/airoha_eth.c |   2 +-
>  drivers/net/ethernet/airoha/airoha_eth.h |  22 ++-
>  drivers/net/ethernet/airoha/airoha_ppe.c | 224 ++++++++++++++++++++++++++-----
>  3 files changed, 212 insertions(+), 36 deletions(-)
> ---
> base-commit: 61f96e684edd28ca40555ec49ea1555df31ba619
> change-id: 20250313-airoha-flowtable-l2b-e0b50d4a3215
> 
> Best regards,
> -- 
> Lorenzo Bianconi <lorenzo@...nel.org>
> 

The v2 addresses all the comments I had for the v1. Thank you!
It looks fine to me.

For the series:
Reviewed-by: Michal Kubiak <michal.kubiak@...el.com>

Thanks,
Michal