netdev - Re: [PATCH iwl-next 1/2] ice: add link_down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_ZiwNUJy7xGeT8m@shredder>
Date: Wed, 9 Apr 2025 15:06:24 +0300
From: Ido Schimmel <idosch@...sch.org>
To: Martyna Szapar-Mudlaw <martyna.szapar-mudlaw@...ux.intel.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
	Michal Kubiak <michal.kubiak@...el.com>
Subject: Re: [PATCH iwl-next 1/2] ice: add link_down_events statistic

On Wed, Apr 09, 2025 at 01:36:23PM +0200, Martyna Szapar-Mudlaw wrote:
> Introduce a new ethtool statistic to ice driver, `link_down_events`,
> to track the number of times the link transitions from up to down.
> This counter can help diagnose issues related to link stability,
> such as port flapping or unexpected link drops.
> 
> The counter increments when a link-down event occurs and is exposed
> via ethtool stats as `link_down_events.nic`.

Are you aware of commit 9a0f830f8026 ("ethtool: linkstate: add a
statistic for PHY down events")?

Better to report this via the generic counter than a driver-specific
one.