netdev - Re: [PATCH net-next 01/13] netlink: specs: rename rtnetlink specs in accordance with family name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m25xjd4jkh.fsf@gmail.com>
Date: Wed, 09 Apr 2025 13:15:42 +0100
From: Donald Hunter <donald.hunter@...il.com>
To: Jacob Keller <jacob.e.keller@...el.com>
Cc: Jakub Kicinski <kuba@...nel.org>,  <davem@...emloft.net>,
  <netdev@...r.kernel.org>,  <edumazet@...gle.com>,  <pabeni@...hat.com>,
  <andrew+netdev@...n.ch>,  <horms@...nel.org>,  <yuyanghuang@...gle.com>,
  <sdf@...ichev.me>,  <gnault@...hat.com>,  <nicolas.dichtel@...nd.com>,
  <petrm@...dia.com>
Subject: Re: [PATCH net-next 01/13] netlink: specs: rename rtnetlink specs
 in accordance with family name

Jacob Keller <jacob.e.keller@...el.com> writes:

> On 4/8/2025 5:03 PM, Jakub Kicinski wrote:
>> The rtnetlink family names are set to rt-$name within the YAML
>> but the files are called rt_$name. C codegen assumes that the
>> generated file name will match the family. We could replace
>> dashes with underscores in the codegen but making sure the
>> family name matches the spec name may be more generally useful.
>> 
>> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
>> ---
> +1 to being more useful to have the family name match the spec name, I
> agree.
>
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

Agree that it's preferable that they match, and that `ynl --family ...`
searches by filename so they really ought to match.

I'll just note that the genl convention is underscores in family names,
if you wanted consistency across all families.

Reviewed-by: Donald Hunter <donald.hunter@...il.com>