netdev - Re: [PATCH net-next] ipv4: remove unnecessary judgment in ip_route_output_key_hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a8742abb-2732-4866-9bf2-4d42410648b1@kernel.org>
Date: Wed, 9 Apr 2025 09:03:31 -0600
From: David Ahern <dsahern@...nel.org>
To: shaozhengchao@....com, netdev@...r.kernel.org, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Cc: horms@...nel.org
Subject: Re: [PATCH net-next] ipv4: remove unnecessary judgment in
 ip_route_output_key_hash_rcu

On 4/8/25 9:33 PM, shaozhengchao@....com wrote:
> From: Zhengchao Shao <shaozhengchao@....com>
> 
> In the ip_route_output_key_cash_rcu function, the input fl4 member saddr is
> first checked to be non-zero before entering multicast, broadcast and
> arbitrary IP address checks. However, the fact that the IP address is not
> 0 has already ruled out the possibility of any address, so remove
> unnecessary judgment.
> 
> Signed-off-by: Zhengchao Shao <shaozhengchao@....com>
> ---
>  net/ipv4/route.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 


Reviewed-by: David Ahern <dsahern@...nel.org>