netdev - Re: [PATCH net-next v2 5/8] xdp: double protect netdev->xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABx7vpXYCaUGzmqq7Y3Sx+KZ10mkhBKeyewEycSJcPH0Dq2YzA@mail.gmail.com>
Date: Wed, 9 Apr 2025 11:40:32 -0700
From: Martin KaFai Lau <iamkafai@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, 
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org, sdf@...ichev.me, 
	hramamurthy@...gle.com, kuniyu@...zon.com, jdamato@...tly.com, 
	bpf@...r.kernel.org
Subject: Re: [PATCH net-next v2 5/8] xdp: double protect netdev->xdp_flags
 with netdev->lock

On Tue, Apr 8, 2025 at 1:01 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> Protect xdp_features with netdev->lock. This way pure readers
> no longer have to take rtnl_lock to access the field.
>
> This includes calling NETDEV_XDP_FEAT_CHANGE under the lock.
> Looks like that's fine for bonding, the only "real" listener,
> it's the same as ethtool feature change.
>
> In terms of normal drivers - only GVE need special consideration
> (other drivers don't use instance lock or don't support XDP).
> It calls xdp_set_features_flag() helper from gve_init_priv() which
> in turn is called from gve_reset_recovery() (locked), or prior
> to netdev registration. So switch to _locked.

Acked-by: Martin KaFai Lau <martin.lau@...nel.org>