netdev - Re: [RFC PATCH 4/6] net: wwan: add NMEA port support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c2bf904-fc91-409c-9ac3-cce132793594@gmail.com>
Date: Wed, 9 Apr 2025 23:18:24 +0300
From: Sergey Ryazanov <ryazanov.s.a@...il.com>
To: Slark Xiao <slark_xiao@....com>
Cc: Loic Poulain <loic.poulain@....qualcomm.com>,
 Johannes Berg <johannes@...solutions.net>,
 Andrew Lunn <andrew+netdev@...n.ch>, Eric Dumazet <edumazet@...gle.com>,
 "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
 Muhammad Nuzaihan <zaihan@...ealasia.net>, Qiang Yu
 <quic_qianyu@...cinc.com>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Johan Hovold <johan@...nel.org>
Subject: Re: [RFC PATCH 4/6] net: wwan: add NMEA port support

Hi Slark,

On 09.04.2025 06:54, Slark Xiao wrote:
> Hi Sergey,
> I saw you add WWAN_PORT_NMEA here. And I have a concern, shall we
> add it into mhi_wwan_ctrl.c for mapping "NMEA" channel in
> mhi_wwan_ctrl_match_table since previous QDU100 device has added
> NMEA channel(So only "NMEA" channel is valid in pci_generic.c, but not
> "GNSS" in future).

This patch introduces NMEA port support to the WWAN core which is 
generic entity. Introduced enum item needs only for a driver to interact 
with the WWAN core. How the driver implements support is up to its 
author. If it needs a new definition for MHI implementation, then feel 
free to do it.

--
Sergey