netdev - Re: [PATCH v4 03/13] media: pci: cx18-av-vbi: Replace open-coded parity calculation with parity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <740c7de894d39249665c6333aa3175762cfb13c6.camel@sipsolutions.net>
Date: Thu, 10 Apr 2025 00:06:03 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Arend van Spriel <arend.vanspriel@...adcom.com>, Kuan-Wei Chiu	
 <visitorckw@...il.com>, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
 	dave.hansen@...ux.intel.com, x86@...nel.org, jk@...abs.org,
 joel@....id.au, 	eajames@...ux.ibm.com, andrzej.hajda@...el.com,
 neil.armstrong@...aro.org, 	rfoss@...nel.org,
 maarten.lankhorst@...ux.intel.com, mripard@...nel.org, 
	tzimmermann@...e.de, airlied@...il.com, simona@...ll.ch,
 dmitry.torokhov@...il.com, 	mchehab@...nel.org, awalls@...metrocast.net,
 hverkuil@...all.nl, 	miquel.raynal@...tlin.com, richard@....at,
 vigneshr@...com, 	louis.peens@...igine.com, andrew+netdev@...n.ch,
 davem@...emloft.net, 	edumazet@...gle.com, pabeni@...hat.com,
 parthiban.veerasooran@...rochip.com, 	gregkh@...uxfoundation.org,
 jirislaby@...nel.org, yury.norov@...il.com, 	akpm@...ux-foundation.org,
 jdelvare@...e.com, linux@...ck-us.net, 	alexandre.belloni@...tlin.com,
 pgaj@...ence.com
Cc: hpa@...or.com, alistair@...ple.id.au, linux@...musvillemoes.dk, 
	Laurent.pinchart@...asonboard.com, jonas@...boo.se,
 jernej.skrabec@...il.com, 	kuba@...nel.org, linux-kernel@...r.kernel.org,
 linux-fsi@...ts.ozlabs.org, 	dri-devel@...ts.freedesktop.org,
 linux-input@...r.kernel.org, 	linux-media@...r.kernel.org,
 linux-mtd@...ts.infradead.org, 	oss-drivers@...igine.com,
 netdev@...r.kernel.org, linux-wireless@...r.kernel.org, 
	brcm80211@...ts.linux.dev, brcm80211-dev-list.pdl@...adcom.com, 
	linux-serial@...r.kernel.org, bpf@...r.kernel.org, jserv@...s.ncku.edu.tw, 
	Frank.Li@....com, linux-hwmon@...r.kernel.org,
 linux-i3c@...ts.infradead.org, 	david.laight.linux@...il.com,
 andrew.cooper3@...rix.com, Yu-Chun Lin	 <eleanor15x@...il.com>
Subject: Re: [PATCH v4 03/13] media: pci: cx18-av-vbi: Replace open-coded
 parity calculation with parity_odd()

On Wed, 2025-04-09 at 20:43 +0200, Arend van Spriel wrote:
> 
> This is orthogonal to the change to parity_odd() though. More specific 
> to the new parity_odd() you can now do following as parity_odd() 
> argument is u64:
> 
> 		err = !parity_odd(*(u16 *)p);
> 

Can it though? Need to be careful with alignment with that, I'd think.

johannes