netdev - Re: [PATCH net-next 08/15] ixgbe: add .info_get extension specific for E610 devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250408192843.0736bf09@kernel.org>
Date: Tue, 8 Apr 2025 19:28:43 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com,
 andrew+netdev@...n.ch, netdev@...r.kernel.org, Jedrzej Jagielski
 <jedrzej.jagielski@...el.com>, przemyslaw.kitszel@...el.com,
 jiri@...nulli.us, horms@...nel.org, corbet@....net,
 linux-doc@...r.kernel.org, Mateusz Polchlopek
 <mateusz.polchlopek@...el.com>, Bharath R <bharath.r@...el.com>, Slawomir
 Mrozowicz <slawomirx.mrozowicz@...el.com>, Piotr Kwapulinski
 <piotr.kwapulinski@...el.com>
Subject: Re: [PATCH net-next 08/15] ixgbe: add .info_get extension specific
 for E610 devices

On Mon,  7 Apr 2025 14:51:12 -0700 Tony Nguyen wrote:
> +	err = devlink_info_version_running_put(req, "fw.mgmt.srev", ctx->buf);
> +	if (err)
> +		return err;
> +
> +	ixgbe_info_orom_srev(adapter, ctx);
> +	err = devlink_info_version_running_put(req, "fw.undi.srev", ctx->buf);

Please add a note in the documentation (the iproute2 man page, the main
devlink info one, and in the driver doc) stating that any security
versions reported via devlink are purely informational. Devlink does
not use a secure channel to communicate with the device.