netdev - Re: [PATCH net-next 10/13] tools: ynl-gen: consider dump ops without a do "type-consistent"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3dcaa591-6450-411c-9fe2-2ceb106260c6@intel.com>
Date: Tue, 8 Apr 2025 22:01:03 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, <davem@...emloft.net>
CC: <netdev@...r.kernel.org>, <edumazet@...gle.com>, <pabeni@...hat.com>,
	<andrew+netdev@...n.ch>, <horms@...nel.org>, <donald.hunter@...il.com>,
	<yuyanghuang@...gle.com>, <sdf@...ichev.me>, <gnault@...hat.com>,
	<nicolas.dichtel@...nd.com>, <petrm@...dia.com>
Subject: Re: [PATCH net-next 10/13] tools: ynl-gen: consider dump ops without
 a do "type-consistent"



On 4/8/2025 5:03 PM, Jakub Kicinski wrote:
> If the type for the response to do and dump are the same we don't
> generate it twice. This is called "type_consistent" in the generator.
> Consider operations which only have dump to also be consistent.
> This removes unnecessary "_dump" from the names. There's a number
> of GET ops in classic Netlink which only have dump handlers.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
Makes sense.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>