netdev - Re: [PATCH net-next 12/13] tools: ynl: generate code for rt-addr and add a sample

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4fdcd9d0-b150-41c9-8d50-655e1f38098c@intel.com>
Date: Tue, 8 Apr 2025 22:04:46 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, <davem@...emloft.net>
CC: <netdev@...r.kernel.org>, <edumazet@...gle.com>, <pabeni@...hat.com>,
	<andrew+netdev@...n.ch>, <horms@...nel.org>, <donald.hunter@...il.com>,
	<yuyanghuang@...gle.com>, <sdf@...ichev.me>, <gnault@...hat.com>,
	<nicolas.dichtel@...nd.com>, <petrm@...dia.com>
Subject: Re: [PATCH net-next 12/13] tools: ynl: generate code for rt-addr and
 add a sample



On 4/8/2025 5:03 PM, Jakub Kicinski wrote:
> diff --git a/tools/net/ynl/samples/rt-addr.c b/tools/net/ynl/samples/rt-addr.c
> new file mode 100644
> index 000000000000..c9a6436ad420
> --- /dev/null
> +++ b/tools/net/ynl/samples/rt-addr.c
> @@ -0,0 +1,80 @@
> +int main(int argc, char **argv)
> +{
> +	struct rt_addr_getaddr_list *rsp;
> +	struct rt_addr_getaddr_req *req;
> +	struct ynl_error yerr;
> +	struct ynl_sock *ys;
> +
> +	ys = ynl_sock_create(&ynl_rt_addr_family, &yerr);
> +	if (!ys) {
> +		fprintf(stderr, "YNL: %s\n", yerr.msg);
> +		return 1;
> +	}
> +
> +	req = rt_addr_getaddr_req_alloc();
> +	if (!req)
> +		goto err_destroy;
> +
> +	rsp = rt_addr_getaddr_dump(ys, req);
> +	rt_addr_getaddr_req_free(req);
> +	if (!rsp)
> +		goto err_close;
> +
> +	if (ynl_dump_empty(rsp))
> +		fprintf(stderr, "Error: no addresses reported\n");
> +	ynl_dump_foreach(rsp, addr)
> +		rt_addr_print(addr, 0);
> +	rt_addr_getaddr_list_free(rsp);
> +
> +	ynl_sock_destroy(ys);
> +	return 0;
> +
> +err_close:
> +	fprintf(stderr, "YNL: %s\n", ys->err.msg);
> +err_destroy:
> +	ynl_sock_destroy(ys);
> +	return 2;
> +}
Nice! This makes it a lot simpler to write small tools for dedicated
tasks or debugging vs trying to use one of the other existing libraries.
I think it helps make netlink more accessible, and appreciate the work
to support the classic netlink families, even with their quirks.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

Thanks,
Jake