netdev - Re: [PATCH net-next] pds_core: fix memory leak in pdsc_debugfs_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z/YXQ7N2lCQxCn0L@mev-dev.igk.intel.com>
Date: Wed, 9 Apr 2025 08:44:19 +0200
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: Abdun Nihaal <abdun.nihaal@...il.com>
Cc: shannon.nelson@....com, brett.creeley@....com, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] pds_core: fix memory leak in
 pdsc_debugfs_add_qcq()

On Wed, Apr 09, 2025 at 11:14:48AM +0530, Abdun Nihaal wrote:
> The memory allocated for intr_ctrl_regset, which is passed to
> debugfs_create_regset32() may not be cleaned up when the driver is
> removed. Fix that by using device managed allocation for it.
> 
> Fixes: 45d76f492938 ("pds_core: set up device and adminq")
> Signed-off-by: Abdun Nihaal <abdun.nihaal@...il.com>
> ---
>  drivers/net/ethernet/amd/pds_core/debugfs.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/amd/pds_core/debugfs.c b/drivers/net/ethernet/amd/pds_core/debugfs.c
> index ac37a4e738ae..04c5e3abd8d7 100644
> --- a/drivers/net/ethernet/amd/pds_core/debugfs.c
> +++ b/drivers/net/ethernet/amd/pds_core/debugfs.c
> @@ -154,8 +154,9 @@ void pdsc_debugfs_add_qcq(struct pdsc *pdsc, struct pdsc_qcq *qcq)
>  		debugfs_create_u32("index", 0400, intr_dentry, &intr->index);
>  		debugfs_create_u32("vector", 0400, intr_dentry, &intr->vector);
>  
> -		intr_ctrl_regset = kzalloc(sizeof(*intr_ctrl_regset),
> -					   GFP_KERNEL);
> +		intr_ctrl_regset = devm_kzalloc(pdsc->dev,
> +						sizeof(*intr_ctrl_regset),
> +						GFP_KERNEL);
>  		if (!intr_ctrl_regset)
>  			return;
>  		intr_ctrl_regset->regs = intr_ctrl_regs;

In ionic driver it is also devm_ version, thanks for catching that.
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>

For future submission remember to set correct target (net instead of
net-next as it is a fix)

Thanks,
Michal

> -- 
> 2.47.2