netdev - Re: [PATCH net-next v2 03/13] rxrpc: Allow CHALLENGEs to the passed to the app for a RESPONSE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2099007.1744267705@warthog.procyon.org.uk>
Date: Thu, 10 Apr 2025 07:48:25 +0100
From: David Howells <dhowells@...hat.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: dhowells@...hat.com, netdev@...r.kernel.org,
    Marc Dionne <marc.dionne@...istor.com>,
    "David S.
 Miller" <davem@...emloft.net>,
    Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
    Simon Horman <horms@...nel.org>,
    Christian Brauner <brauner@...nel.org>,
    Chuck Lever <chuck.lever@...cle.com>, linux-afs@...ts.infradead.org,
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 03/13] rxrpc: Allow CHALLENGEs to the passed to the app for a RESPONSE

Jakub Kicinski <kuba@...nel.org> wrote:

> > +	__releases(&rx->sk.sk_lock.slock)
> 
> sparse still complains (or maybe in fact it complains because it sees
> the annotation?):
> 
> net/rxrpc/oob.c:173:12: warning: context imbalance in 'rxrpc_respond_to_oob' - wrong count at exit
> net/rxrpc/oob.c:223:5: warning: context imbalance in 'rxrpc_sendmsg_oob' - wrong count at exit
> 
> Not a deal breaker, just wanted to mention it.

Yeah.  I'm pretty sure I have the releases in all the right place.  The
problem might be that *release_sock()* lacks the annotation.

David