netdev - RE: [PATCH 1/7] irqbypass: Drop pointless and misleading THIS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR11MB52768809C6ABA6EE31A283FE8CB72@BN9PR11MB5276.namprd11.prod.outlook.com>
Date: Thu, 10 Apr 2025 07:12:17 +0000
From: "Tian, Kevin" <kevin.tian@...el.com>
To: Sean Christopherson <seanjc@...gle.com>, "Michael S. Tsirkin"
	<mst@...hat.com>, Jason Wang <jasowang@...hat.com>, Paolo Bonzini
	<pbonzini@...hat.com>, Alex Williamson <alex.williamson@...hat.com>
CC: "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"virtualization@...ts.linux.dev" <virtualization@...ts.linux.dev>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Oliver Upton
	<oliver.upton@...ux.dev>, David Matlack <dmatlack@...gle.com>, Like Xu
	<like.xu.linux@...il.com>, Yong He <alexyonghe@...cent.com>
Subject: RE: [PATCH 1/7] irqbypass: Drop pointless and misleading THIS_MODULE
 get/put

> From: Sean Christopherson <seanjc@...gle.com>
> Sent: Saturday, April 5, 2025 5:15 AM
> 
> Drop irqbypass.ko's superfluous and misleading get/put calls on
> THIS_MODULE.  A module taking a reference to itself is useless; no amount
> of checks will prevent doom and destruction if the caller hasn't already
> guaranteed the liveliness of the module (this goes for any module).  E.g.
> if try_module_get() fails because irqbypass.ko is being unloaded, then the
> kernel has already hit a use-after-free by virtue of executing code whose
> lifecycle is tied to irqbypass.ko.
> 
> Signed-off-by: Sean Christopherson <seanjc@...gle.com>

Reviewed-by: Kevin Tian <kevin.tian@...el.com>