netdev - Re: [PATCH net-next v9 1/2] page_pool: Move pp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D92K7SAU1A06.1APBVXB2AK2HW@nvidia.com>
Date: Wed, 09 Apr 2025 21:15:28 -0400
From: "Zi Yan" <ziy@...dia.com>
To: Toke Høiland-Jørgensen <toke@...hat.com>, "David
 S. Miller" <davem@...emloft.net>, "Jakub Kicinski" <kuba@...nel.org>,
 "Jesper Dangaard Brouer" <hawk@...nel.org>, "Saeed Mahameed"
 <saeedm@...dia.com>, "Leon Romanovsky" <leon@...nel.org>, "Tariq Toukan"
 <tariqt@...dia.com>, "Andrew Lunn" <andrew+netdev@...n.ch>, "Eric Dumazet"
 <edumazet@...gle.com>, "Paolo Abeni" <pabeni@...hat.com>, "Ilias
 Apalodimas" <ilias.apalodimas@...aro.org>, "Simon Horman"
 <horms@...nel.org>, "Andrew Morton" <akpm@...ux-foundation.org>, "Mina
 Almasry" <almasrymina@...gle.com>, "Yonglong Liu" <liuyonglong@...wei.com>,
 "Yunsheng Lin" <linyunsheng@...wei.com>, "Pavel Begunkov"
 <asml.silence@...il.com>, "Matthew Wilcox" <willy@...radead.org>
Cc: <netdev@...r.kernel.org>, <bpf@...r.kernel.org>,
 <linux-rdma@...r.kernel.org>, <linux-mm@...ck.org>
Subject: Re: [PATCH net-next v9 1/2] page_pool: Move pp_magic check into
 helper functions

On Wed Apr 9, 2025 at 6:41 AM EDT, Toke Høiland-Jørgensen wrote:
> Since we are about to stash some more information into the pp_magic
> field, let's move the magic signature checks into a pair of helper
> functions so it can be changed in one place.
>
> Reviewed-by: Mina Almasry <almasrymina@...gle.com>
> Tested-by: Yonglong Liu <liuyonglong@...wei.com>
> Acked-by: Jesper Dangaard Brouer <hawk@...nel.org>
> Reviewed-by: Ilias Apalodimas <ilias.apalodimas@...aro.org>
> Signed-off-by: Toke Høiland-Jørgensen <toke@...hat.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c |  4 ++--
>  include/linux/mm.h                               | 20 ++++++++++++++++++++
>  mm/page_alloc.c                                  |  8 ++------
>  net/core/netmem_priv.h                           |  5 +++++
>  net/core/skbuff.c                                | 16 ++--------------
>  net/core/xdp.c                                   |  4 ++--
>  6 files changed, 33 insertions(+), 24 deletions(-)
>

LGTM. Reviewed-by: Zi Yan <ziy@...dia.com>

-- 
Best Regards,
Yan, Zi