netdev - Re: [PATCH v12 01/23] cxl: add type2 device basic support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <671a2db2-1c67-43f9-8205-74b682043e8e@amd.com>
Date: Thu, 10 Apr 2025 09:12:04 +0100
From: Alejandro Lucero Palau <alucerop@....com>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 alejandro.lucero-palau@....com
Cc: linux-cxl@...r.kernel.org, netdev@...r.kernel.org,
 dan.j.williams@...el.com, edward.cree@....com, davem@...emloft.net,
 kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com, dave.jiang@...el.com
Subject: Re: [PATCH v12 01/23] cxl: add type2 device basic support


On 4/7/25 10:50, Alejandro Lucero Palau wrote:
>
> On 4/4/25 16:24, Jonathan Cameron wrote:
>>>   /* SPDX-License-Identifier: GPL-2.0-only */
>>>   /* Copyright(c) 2020 Intel Corporation. All rights reserved. */
>>> -#ifndef __CXL_PCI_H__
>>> -#define __CXL_PCI_H__
>>> +#ifndef __CXLPCI_H__
>>> +#define __CXLPCI_H__
>> Might be reasonable, but I don't think it belongs in this patch.
>>
>
> It is as I'm adding the new include/cxl/pci.h file which uses the old 
> name used here.
>
>
>>
>>> +
>>> +#ifndef __CXL_H
>>> +#define __CXL_H
>> Similar to below. I think we need the guards here and in
>> drivers/cxl/cxl.h to be more different.
>
>
> I forgot this clash. What about __CXL_CXL_H for the one in include/cxl?
>
>

For v13 I will use __CXL_CXL_H and __CXL_CXL_PCI_H for those new files 
in include/cxl .


Anyone with a better suggestion, please tell me.