netdev - Re: [PATCH v1 net-next 05/14] vxlan: Convert vxlan_exit_batch_rtnl() to ->exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f87b7ca9-103a-423b-a9e6-6cb886a48cf4@blackwall.org>
Date: Thu, 10 Apr 2025 12:07:57 +0300
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Kuniyuki Iwashima <kuniyu@...zon.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: Simon Horman <horms@...nel.org>, Kuniyuki Iwashima <kuni1840@...il.com>,
 netdev@...r.kernel.org, Andrew Lunn <andrew+netdev@...n.ch>
Subject: Re: [PATCH v1 net-next 05/14] vxlan: Convert vxlan_exit_batch_rtnl()
 to ->exit_rtnl().

On 4/10/25 05:19, Kuniyuki Iwashima wrote:
> vxlan_exit_batch_rtnl() iterates the dying netns list and
> performs the same operations for each.
> 
> Let's use ->exit_rtnl().
> 
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>
> ---
> Cc: Andrew Lunn <andrew+netdev@...n.ch>
> ---
>  drivers/net/vxlan/vxlan_core.c | 18 +++++++-----------
>  1 file changed, 7 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
> index 8c49e903cb3a..6ee61334719b 100644
> --- a/drivers/net/vxlan/vxlan_core.c
> +++ b/drivers/net/vxlan/vxlan_core.c
> @@ -4966,19 +4966,15 @@ static void __net_exit vxlan_destroy_tunnels(struct vxlan_net *vn,
>  		vxlan_dellink(vxlan->dev, dev_to_kill);
>  }
>  
> -static void __net_exit vxlan_exit_batch_rtnl(struct list_head *net_list,
> -					     struct list_head *dev_to_kill)
> +static void __net_exit vxlan_exit_rtnl(struct net *net,
> +				       struct list_head *dev_to_kill)
>  {
> -	struct net *net;
> -
> -	ASSERT_RTNL();
> -	list_for_each_entry(net, net_list, exit_list) {
> -		struct vxlan_net *vn = net_generic(net, vxlan_net_id);
> +	struct vxlan_net *vn = net_generic(net, vxlan_net_id);
>  
> -		__unregister_nexthop_notifier(net, &vn->nexthop_notifier_block);
> +	ASSERT_RTNL_NET(net);
>  
> -		vxlan_destroy_tunnels(vn, dev_to_kill);
> -	}
> +	__unregister_nexthop_notifier(net, &vn->nexthop_notifier_block);
> +	vxlan_destroy_tunnels(vn, dev_to_kill);
>  }
>  
>  static void __net_exit vxlan_exit_net(struct net *net)
> @@ -4992,7 +4988,7 @@ static void __net_exit vxlan_exit_net(struct net *net)
>  
>  static struct pernet_operations vxlan_net_ops = {
>  	.init = vxlan_init_net,
> -	.exit_batch_rtnl = vxlan_exit_batch_rtnl,
> +	.exit_rtnl = vxlan_exit_rtnl,
>  	.exit = vxlan_exit_net,
>  	.id   = &vxlan_net_id,
>  	.size = sizeof(struct vxlan_net),

Reviewed-by: Nikolay Aleksandrov <razor@...ckwall.org>