netdev - Re: [PATCH net v3] batman-adv: Fix double-hold of meshif when getting enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d72376b8-a794-4c47-b981-11df6e17e417@redhat.com>
Date: Thu, 10 Apr 2025 12:13:25 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Sven Eckelmann <sven@...fation.org>,
 Simon Wunderlich <sw@...onwunderlich.de>
Cc: "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 netdev@...r.kernel.org
Subject: Re: [PATCH net v3] batman-adv: Fix double-hold of meshif when getting
 enabled

On 4/9/25 9:35 AM, Sven Eckelmann wrote:
> It was originally meant to replace the dev_hold with netdev_hold. But this
> was missed in this place and thus there was an imbalance when trying to
> remove the interfaces.
> 
> Fixes: 00b35530811f ("batman-adv: adopt netdev_hold() / netdev_put()")
> Signed-off-by: Sven Eckelmann <sven@...fation.org>

You must wait at least 24h before reposting, see:

https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/process/maintainer-netdev.rst#L15

Also this is somewhat strange: the same patch come from 2 different
persons (sometimes with garbled SoBs), and we usually receive PR for
batman patches.

@Svev, @Simon: could you please double check you are on the same page
and clarify the intent here?

Thanks,

Paolo