netdev - Re: [PATCH net-next v2] sock: Correct error checking condition for (assign|release)_proto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed3ce657-01e1-4d4a-bfbb-062d5ae765f9@icloud.com>
Date: Thu, 10 Apr 2025 18:47:03 +0800
From: Zijun Hu <zijun_hu@...oud.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: dada1@...mosbay.com, davem@...emloft.net, edumazet@...gle.com,
 horms@...nel.org, kuba@...nel.org, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, pabeni@...hat.com, quic_zijuhu@...cinc.com,
 willemb@...gle.com, xemul@...nvz.org
Subject: Re: [PATCH net-next v2] sock: Correct error checking condition for
 (assign|release)_proto_idx()

On 2025/4/10 11:53, Kuniyuki Iwashima wrote:
>> [PATCH net-next v2] sock: Correct error checking condition for (assign|release)_proto_idx()
> Maybe net instead of net-next ?
> 

Either net or net-next is okay.

> 
> From: Zijun Hu <zijun_hu@...oud.com>
> Date: Thu, 10 Apr 2025 09:01:27 +0800
>> From: Zijun Hu <quic_zijuhu@...cinc.com>
>>
>> (assign|release)_proto_idx() wrongly check find_first_zero_bit() failure
>> by condition '(prot->inuse_idx == PROTO_INUSE_NR - 1)' obviously.
>>
>> Fix by correcting the condition to '(prot->inuse_idx == PROTO_INUSE_NR)'
>>
>> Fixes: 13ff3d6fa4e6 ("[SOCK]: Enumerate struct proto-s to facilitate percpu inuse accounting (v2).")
>> Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>
> Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>